-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need add rxjs 7 support for version 9.x.x #472
Comments
Yes I think at the time when v9 was release there probably was no rxjs v7 yet. But you should have no problem using rxjs v7 even with v9, just disable NPM from checking peer dependencies (either via But I'm not planning on maintaining previous major versions which means anything below v10 does not get any updates as this will increase the burden of maintenance of the library. |
Ok, I understand you. Unfortunately, v10 does not work with angular 12. And I can't update up to 13, because we need support IE =( |
@gund does v10 could work with angular 12? I try and got error in runtime, when create component. Angular 12 have another signature of this method. |
Oh yes, I forgot about that change, I will need to add backwards compatibility for that piece of code. |
Great! Thank you very much |
# [10.2.0-next.2](v10.2.0-next.1...v10.2.0-next.2) (2022-06-16) ### Bug Fixes * **component:** add compatibility with Angular v12 to component rendering ([18c3922](18c3922)), closes [#472](#472)
@DexterIA could you please give a try to |
@gund Yes, sure |
This has been released on 10.2.0 |
@gund I've got error when build app, after update to 10.2.0
Look's like it work only in Angular 14 Interesting, storybook build completes without errors and components work's fine. |
Hmm that looks strange, this seems like a specific version check during a build time as there is no hard dependency on Angular v14 in the library. @DexterIA could you please paste the details of |
|
Ok, from the response from Angular team it is not supported to use library compiled with newer angular in the app that is using older angular version. This basically means that you either need to upgrade your app to angular v14 or disable peer dependencies check and keep using v9. |
@gund This crutch is not needed anymore
|
Yep, I just removed it from the latest release, thanks 😊 |
ng-dynamic-component/projects/ng-dynamic-component/package.json
Line 23 in 64c799b
I suggest change this to "rxjs": "^6.0.0 | ^7.0.0"
ng-dynamic-component should have no problem working on rxjs 7
Angular 12 currently support rxjs 7, but ng-dynamic-component blocks update rxjs up to 7 version.
The text was updated successfully, but these errors were encountered: