Ability to provide custom NgModuleRef #495
Conversation
There was a problem hiding this comment.
Thanks for the PR!
Could you please also add unit tests for this new options?
To test ngModuleRef you could provide something in that module and then try to inject that in the injected component's injector to see if it's available.
Same strategy could be used for environmentInjector option as well.
P.S. You can use Github Codespaces to make changes fully online in full VScode IDE and run build/tests there without having to install anything locally:
There was a problem hiding this comment.
Looks good!
Before merging I'd like to make a few small adjustments to match the types with Angular and also add the following text to the readme.md file as a documentation after this location:
**Since v10.6.0**: You can provide custom NgModuleRef (`[ndcDynamicNgModuleRef]`)
or EnvironmentInjector (`[ndcDynamicEnvironmentInjector]`) for your dynamic component.Alternatively I can make those changes myself but you would have to allow maintainers to push to this PR (I've already made those changes locally on this PR but have no permissions to push them).
projects/ng-dynamic-component/src/lib/dynamic.component.spec.ts
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in version 10.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.