Add noscript notice #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@corollari you are awesome! Thanks. Yeah, I'd want to do something like that too :/ unfortunately requires JS though so kinda self-defeating. Thanks for being an OSS contributor!!! 👏 👏 👏 Pulling! Come introduce yourself in the super friendly chat room https://gitter.im/amark/gun :D |
|
Thanks! |
|
@corollari you are an all star! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a noscript notice to the page for users who have disabled javascript, as requested in a Hacker News comment.
Given that this SPA is pulling its content from wiki pages, it'd be awesome if we could change the noscript tag to contain a link to the specific wiki page each article/tutorial is about, but I haven't been able to think of any way to enable this while maintaining the site completely static.