Refactored client library code for Data Types for consolidating type transformation logic #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-reuse. This refactoring is attempting the following benefits: 1. Code reuse for common value encoding conversions 2. Reducing the number of places when adding a new data-type, especially the type-related conversion logic. 3. Refactor the existing primitive types to use the new helper functions to simplify existing code.
… set, setting query parameters and mutations
…mation logic in one place.
This refactoring is attempting the following benefits:
1. Code reuse for common value encoding conversions
2. Reducing the number of places when adding a new data-type, especially the type-related conversion logic.
…verters used by GenericValue type - String, Json, PG Jsonb, Bool and Float64. This also covers all the possible wire encoding values (namely Number, Bool and String).
…using the new Converter framework will help demonstrate the ease-of-use benefits
…er. WIP - A simple prototype code-replacer
…er (missing files from last commit). WIP - A simple prototype code-replacer
…n for Value default array implementation class and a test that must override public methods.
…r places that need a manual review
# Conflicts: # google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/ForwardingStructReader.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/Key.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/Type.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/ValueBinder.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/StatementTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueBinderTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/RandomResultSetGenerator.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ReadWriteTransactionTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored client library code to consolidaet all Data Types transformation logic in one place.
[Note: This PR is raised on a fork of the java-spanner client repo. It is currently a prototype, and once things look promising a separate PR will be raised for merging this to the official repo.]