Adding NUMERIC type using refactoring improvements and code auto-generation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns to the generated code; code tweaks will be done in a following commit. This type was previously manually removed, and adding it back using the auto-generation framework and refactored codebase will help with measuring the benefits of these changes
This commit builds on top of the auto-generated code for NUMERIC type and adds: - A converter implementation containing most of the value-representation logic. - Code formatting cleanup and minor fixes in the autogenerated code
The NUMERIC type was deleted to demonstrate the Java library simplification changes when adding them back. Test simplification was out of scope of the initial work, hence the old tests are now being added back as-they-were.
…for wire-protocol-to-type conversion logic in Key construction
…g_new_framework # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueBinderTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/RandomResultSetGenerator.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ReadWriteTransactionTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding NUMERIC type using refactoring improvements and code auto-generation. This type was previously manually removed, and adding it back using the auto-generation framework and refactored codebase will help with measuring the benefits of these changes
Individual commits in this PR will highlight the main steps in the workflow: