Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Refactored & fixed. #81

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Refactored & fixed. #81

merged 3 commits into from
Jun 11, 2021

Conversation

neoblizz
Copy link
Member

Reoccuring segfault that happens seemingly with very minor changes (was happening earlier with the SSSP application as well). Need help debugging and verifying it happens on Linux-based machines as well and not just in my version.

@neoblizz neoblizz changed the base branch from master to dev May 27, 2021 16:24
@neoblizz neoblizz added 🍻 help wanted Extra attention is needed 🏭 build Build related issues. labels May 27, 2021
@neoblizz
Copy link
Member Author

neoblizz commented Jun 9, 2021

Still need help with this, if @crozhon has time, any pointers will be appreciated! I am not even sure where the error is. One thing I can do better is maybe to remove the style changes from actual changes to make the diff easier to read.

@crozhon
Copy link
Contributor

crozhon commented Jun 11, 2021

Commenting out main in kcore.cu let me find this issue. Now it's giving normal compiler errors for you again (something about frontier_t being undefined). Hope this helps.

@neoblizz
Copy link
Member Author

neoblizz commented Jun 11, 2021

Commenting out main in kcore.cu let me find this issue. Now it's giving normal compiler errors for you again (something about frontier_t being undefined). Hope this helps.

HUGE! I'll take a look at it again. Thank you so much! How did you figure out that was the issue? Any compile-time debugging tricks or just reading through the code?

@crozhon
Copy link
Contributor

crozhon commented Jun 11, 2021

I built with test_kcore commented out, and it pointed to that error in kcore.hxx. I think maybe it hitting multiple compiler errors caused the segfault, so getting rid of the frontier_t error fixed it? Not sure. Maybe it occurred as part of printing the error?

@neoblizz neoblizz changed the title Segmentation Fault w/ no output Refactored & fixed. Jun 11, 2021
@neoblizz neoblizz merged commit b72b779 into dev Jun 11, 2021
@neoblizz neoblizz deleted the seg_fault branch June 11, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏭 build Build related issues. 🍻 help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants