Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spanish corpus #440

Merged
merged 2 commits into from Dec 2, 2016
Merged

Conversation

ender-null
Copy link
Contributor

Some characters had unreadable characters, so I replaced them.

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. Thank you!

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks like tests are failing with these changes (https://travis-ci.org/gunthercox/ChatterBot/jobs/180028015)

Copy link
Contributor Author

@ender-null ender-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the breakline that was breaking the JSON.

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you.

@gunthercox gunthercox merged commit 8f7cd8a into gunthercox:master Dec 2, 2016
@ender-null ender-null deleted the fixed-spanish-corpus branch December 2, 2016 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants