New math operations #449
Merged
New math operations #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunthercox
approved these changes
Dec 1, 2016
| string += str(is_chunk_integer) + ' ' | ||
| for chunk in chunks: | ||
| for checker in ['is_integer', 'is_float', 'is_operator', 'is_constant', 'is_function']: | ||
| result = getattr(self, checker)(chunk) |
There was a problem hiding this comment.
This is a really nice revision to the previous setup.
| self.assertEqual(response.text, '3.141693 + 2.718281 = 5.859974') | ||
|
|
||
| def test_math_functions(self): | ||
| statement = Statement('What is log ( 5 + 6 ) * sqrt ( 12 ) ?') |
There was a problem hiding this comment.
Thank you for including tests!
|
Thanks a lot for your enthusiasm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are:
if/elsestatements)"log(3+4)"to be processed, instead of just"log ( 3 + 4 ) ")I hope this is in keeping with coding standards of the project, especially the addition of a class attribute (
functionsinMathematicalEvaluation). Also, there could be more math functions and constants.