Response list now stores occurrence count #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunthercox
force-pushed
the
response_structure
branch
from
ac52de8
to
7001416
Compare
This makes it possible to create logic adapters that use additional meta data from statements to select a response.
Since the list of statement objects is now passed to the logic adapter, have the logic adapter return the matching statement instead of doing another lookup.
This was due to an issue in a dependency where the empty string was being evaluated as false. The minimum required value of jsondb bas been set to prevent this in the future.
gunthercox
force-pushed
the
response_structure
branch
from
0f94f1e
to
6823dda
Compare
gunthercox
force-pushed
the
response_structure
branch
from
a94a7c4
to
6262b9b
Compare
Signatures are not used yet. In the future they will be used to hold meta data about a response, such as who said it.
gunthercox
added a commit
that referenced
this pull request
Oct 17, 2015
Response list now stores occurrence count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes changes that will make the process of generating responses to known input more accurate.
Before this pull request, each statement object stored a count (
occurrences), representing the number of times the statement had occurred, and a list of responses (in_response_to), representing the list of other statements that the current statement has been issued in response to.This pull request removes the occurrence count from the statement object and introduces a response object. Each response object holds the text of the response statement and the count of the number of times the current statement has been used to respond to it.
By making these changes a fundamental issue with the previous algorithm is solved. The problem with using the weighting of occurrence count to select responses is that some statements may tend to occur frequently, but that does not necessarily imply an equal level of frequency toward all possible responses.
Closes #46