Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Indexing blur test bench against toodee" #19

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

gunvirranu
Copy link
Owner

@gunvirranu gunvirranu commented Sep 8, 2020

Reverts #16. This removes all toodee related code from the test-bench suite.

Multiple reasons:

  • toodee uses (col, row) indexing, so blur_by_index is probably just slightly slower than it could be
  • toodee supports resizing, which isn't a use-case of this lib, so it's not exactly a good comparison
  • The idiomatic blur using toodee doesn't seem too different from indexing, nor is it actually "nice" code

So there isn't much use to comparing with toodee. Considering comparing with imgref, but that's for later.

@gunvirranu gunvirranu added the testbench CI or test-bench suite changes label Sep 8, 2020
@gunvirranu gunvirranu merged commit 1058eec into master Sep 8, 2020
@gunvirranu gunvirranu deleted the revert-16-toodee branch September 8, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testbench CI or test-bench suite changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant