Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NoveltyEvaluator; new EntropyEvaluator #205

Merged
merged 17 commits into from
Oct 29, 2017
Merged

Conversation

dvelten
Copy link
Contributor

@dvelten dvelten commented Oct 23, 2017

The Implementation of NoveltyEvaluator is not that mentioned in the paper. But it is also a well known and often used Evaluator. But it is more a 'Diversity'-'Entropy' - Evaluator only.

I have now created two Implementations. The new corrected NoveltyEvaluator and an EntropyEvaluator containing an modified version of the old NoveltyEvaluator.

Both Implementation use Entropy or Information to do calculations. The new EntropyEvaluator does not take into account if the item purchased is popular or unpopular in respect of probability purchased.

Instead of this the probability space is different.

NoveltyEvaluator: Probability of item purchased
EntropyEvaluator: Probability of item to be in the recommender result list

Both Implementations could be thought to make the same for loops to sum the Entropy of one result list.

But in the EntropyEvaluator you can do an optimization and rewrite the for loop over users into an for loop over items with the pre-calculated item counts (item probabilities).

Best wishes

Daniel

@dvelten
Copy link
Contributor Author

dvelten commented Oct 23, 2017

Sorry for change list: There are only 2 new classes and the config file.

Have had problems to sync my fork. (I am new to github)

@SunYatong SunYatong merged commit 285964f into guoguibing:2.0.0 Oct 29, 2017
@SunYatong
Copy link
Collaborator

@dvelten
Hi, sorry about the delay. I have merged your code and did some modification at #206, the result didn't change and the implementation is more efficient and concise. Please check my code in case I made mistakes.

BTW, we can include your documentation of NMFItemItem into ours(https://www.librec.net/dokuwiki/doku.php). You can email it to me at sunyatong65536@gmail.com after your optimization.

Thank you for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants