Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The global_step update in optimization_gpu.py (line 74-75) is redundant. #24

Closed
xuegsh opened this issue Nov 14, 2020 · 2 comments
Closed

The global_step update in optimization_gpu.py (line 74-75) is redundant. #24

xuegsh opened this issue Nov 14, 2020 · 2 comments

Comments

@xuegsh
Copy link

xuegsh commented Nov 14, 2020

You didn't override the apply_gradients function in class AdamWeightDecayOptimizer, Normally the global step update is done inside of apply_gradients.
@guotong1988
Copy link
Owner

Thank you.

@guotong1988
Copy link
Owner

Fixed.

@guotong1988 guotong1988 mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guotong1988 @xuegsh