Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-haraki generates a different result with cargo-sort #65

Closed
TennyZhuang opened this issue Jan 19, 2023 · 3 comments · Fixed by #66
Closed

cargo-haraki generates a different result with cargo-sort #65

TennyZhuang opened this issue Jan 19, 2023 · 3 comments · Fixed by #66

Comments

@TennyZhuang
Copy link

So we can't use the two checkers both.

Examples:

checkout the following two commits and the generated content will flip forever.
@TennyZhuang
Copy link
Author

The key difference:

image

@TennyZhuang TennyZhuang mentioned this issue Jan 19, 2023
Merged
@sunshowers
Copy link
Member

Thanks for filing this. I agree that hakari isn't quite behaving right here: it's sorting (hashbrown, 0.12) before (hashbrown, 0.13) while it should actually sort alphabetically.

sunshowers added a commit to sunshowers/guppy that referenced this issue Jan 19, 2023
@sunshowers
[hakari] add a new format version that sorts dependencies alphabetically
6de7f75 
In some cases, we weren't producing output that was exactly sorted.

Fixes guppy-rs#65.
@sunshowers sunshowers mentioned this issue Jan 19, 2023
Merged
sunshowers added a commit to sunshowers/guppy that referenced this issue Jan 19, 2023
@sunshowers
[hakari] add a new format version that sorts dependencies alphabetically
235b476 
In some cases, we weren't producing output that was exactly sorted.

Fixes guppy-rs#65.
@sunshowers
Copy link
Member

This is now out as part of cargo-hakari 0.9.23, once you bump the dep-format-version to 4 in hakari.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hakari] add a new format version that sorts dependencies alphabetically sunshowers/guppy
2 participants
@sunshowers @TennyZhuang