Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precision feature #27

Merged
merged 4 commits into from Mar 27, 2021
Merged

Add precision feature #27

merged 4 commits into from Mar 27, 2021

Conversation

quackduck
Copy link
Contributor

Users can then have the option to set their own label precision.

@coveralls
Copy link

coveralls commented Mar 15, 2021 •
edited

Pull Request Test Coverage Report for Build 83

  • 7 of 10 (70.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 72.026%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/asciigraph/main.go 0 3 0.0%
Totals Coverage Status
Change from base Build 86: -0.4%
Covered Lines: 224
Relevant Lines: 311
💛 - Coveralls

@guptarohit
Copy link
Owner

LGTM 👍 would be nice to also add a param flag for this in CLI utility and test cases.

@quackduck
Copy link
Contributor Author

I'm not sure of how to do that? Could you do it?

@guptarohit
Copy link
Owner

sure, I'll add these changes ✌️

@guptarohit guptarohit merged commit d553cef into guptarohit:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guptarohit guptarohit guptarohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quackduck @coveralls @guptarohit