Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Improve API routes #4

Closed
bogas04 opened this issue Oct 27, 2016 · 3 comments
Closed

Improve API routes #4

bogas04 opened this issue Oct 27, 2016 · 3 comments
Assignees

Comments

@bogas04
Copy link
Contributor

bogas04 commented Oct 27, 2016

It's very crude right now. You can try a cleaner scheme, something like:

mode=1 becomes /search/:query?source_id=(0|1|2|3)&type=(0|1|2|3)...
mode=2 becomes /shabad/:shabad_id
mode=3 becomes /ang/:ang_id?source_id=(0|1|2|3)

Keeping format=json, writer -> writer_id=0, recnum -> count=10, raag -> raag_id=0 as defaults to clean up the route a bit. Also renaming them to match the response of API.

Also using camelCase or snake_case as one standard throughout API (route and response) would be nice.

@sarabveer
Copy link
Member

sarabveer commented Oct 28, 2016

Yea, thinking about this, need to learn how to implement with PHP though.

@sarabveer sarabveer self-assigned this Oct 28, 2016
@bogas04
Copy link
Contributor Author

bogas04 commented Oct 28, 2016

You can use SLIM framework http://www.slimframework.com

On Oct 28, 2016 11:28 AM, "Sarabveer Singh" notifications@github.com
wrote:

Yea, thinking about this, need to leanr how to implement with PHP though.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF5DVW3JZge8xgU68gLr4Q0caYsAKRchks5q4V3OgaJpZM4Kh4mm
.

@sarabveer
Copy link
Member

I'm removing XML Support, as its not used and hard to maintain.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants