Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Equal method to nulltypes. #36

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

MarkKremer
Copy link
Contributor

I added the methods as discussed in #35 . The methods are called Equal instead of Equals (with -s) to be more consistent with the go library.

Interesting bits:

  • Time can be compared using Equal (uses time.Time.Equals) and ExactEqual (uses the ==-operator)
  • Equal is implemented for Float. The doc above the method mentions that comparing floats is not always recommended.

@guregu
Copy link
Owner

guregu commented Aug 22, 2018

Thanks for the PR! LGTM. I’ll add the equivalent methods to the zero package and merge this soon (ETA: this weekend)

@guregu guregu mentioned this pull request Jul 23, 2019
3 tasks
@abramche
Copy link

Any news @guregu?

@guregu guregu merged commit cc180c7 into guregu:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants