-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 8ball command #176
Added 8ball command #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks.
And please open an issue and get it approved next time.
Co-authored-by: Vivek Ashok <vivekashok1221@gmail.com>
Co-authored-by: Vivek Ashok <vivekashok1221@gmail.com>
I will commit these changes locally. I thought this came under gurkbot#166 Sorry. |
Am not sure if I should move replies into |
All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost everything looks good. Minor change.
Co-authored-by: Vivek Ashok <vivekashok1221@gmail.com>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
My first LGTM. This will forever be remembered by me. Thank you, looking forward for it to get merged. |
sup |
Can we wrap this up quick? If you have changes to request, please do, since I will be busy in the upcoming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nice Nice thanks |
Merge has been reverted due to a Git history problem. Please use branches when making pull requests. I'd also like to see an issue before the next PR. |
Added an 8ball command