Allow AD auth with either sAMAccountName or userPrincipalName #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because userPrincipalName can look like an email address, AD authentication will never happen if fallback is enabled. So fallback logic was moved to where it will only be triggered if AD authentication fails. This also permitted removal of the email comparison since it's no longer needed, allowing more flexibility for local usernames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we're using TestRail and we'd like to authenticate to AD using userPrincipalName, so I updated the example to be able to do either sAMAccountName or userPrincipalName.
Because userPrincipalName can look like an email address (e.g. someone@cohowinery.com), with the previous code AD authentication would never happen if fallback was enabled. So fallback logic was moved to where it will only be triggered if AD authentication fails. This also permitted removal of the email comparison since it's no longer needed, so local usernames are no longer restricted to email addresses.
I also updated to the latest versions from docs.gurock.com.
Thanks!