Only creating the div if showing recent posts #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I thought that it's better to avoid adding the recent-posts div to the DOM if that section is not enabled. Also, I've modified the logic so that if there are no posts, it will be considered disabled instead of showing the title with no further content. Hope this is Ok.
|
Thanks @mancku |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I thought that it's better to avoid adding the recent-posts div to the DOM if that section is not enabled. Also, I've modified the logic so that if there are no posts, it will be considered disabled instead of showing the title with no further content.
Hope this is Ok.