Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add primary-font to experience #91

Merged
merged 1 commit into from
Feb 2, 2023
Merged

add primary-font to experience #91

merged 1 commit into from
Feb 2, 2023

Conversation

pantera-rosa
Copy link
Contributor

@pantera-rosa pantera-rosa commented Feb 1, 2023

overview
keeping font consistent with the rest of the experience section. it was defaulting to Lora (the default body font) but we are using Alata (the primary font) for the rest of the "experience" section.

questions
ideally, we'd want to have a strict style guide for the website where it's explicit what "primary" means (is it just meant for headers? for body? just for the hero? etc) and styles are used consistently throughout the site - or, just use all the same font everywhere, which also is a good alternative. current setup is a bit confusing (primary-font is used in the header, post titles, hero, menu, and experience body)

current state of example experience section
Screen Shot 2023-01-31 at 11 41 50 PM

job section font before:
Screen Shot 2023-01-31 at 11 34 29 PM

job section font after:
Screen Shot 2023-01-31 at 11 34 20 PM

keeping font consistent
@pantera-rosa pantera-rosa marked this pull request as ready for review February 1, 2023 07:47
@gurusabarish
Copy link
Owner

Thanks ❤️

@gurusabarish gurusabarish merged commit 6930cf2 into gurusabarish:master Feb 2, 2023
@pantera-rosa pantera-rosa deleted the patch-1 branch February 2, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants