Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paginationAccessibilityLabels for Improved Accessibility in Pagination #185

Conversation

yanagisawahidetoshi
Copy link
Contributor

This pull request addresses the following issues related to accessibility in the Pagination component:

  1. When using screen readers like VoiceOver, focusing on the Pagination component does not result in any audible feedback.
  2. There is no way to externally set accessibility properties for the Pagination component.

To resolve these issues, the following changes have been made:

  • Added a new prop paginationAccessibilityLabels to allow setting custom labels for accessibility purposes.
  • When paginationAccessibilityLabels is provided, the screen reader will read the specified labels.
  • If paginationAccessibilityLabels is not set, the screen reader will skip reading the Pagination component.

These enhancements aim to improve the accessibility of the Pagination component for users relying on screen readers and other assistive technologies.

Copy link

what-the-diff bot commented Apr 7, 2024

PR Summary

  • Improved Accessibility in Pagination Component
    An addition has been made to the 'Pagination' feature of our software. A new property called 'paginationAccessibilityLabels' has been introduced. It is essentially a list of textual descriptions that add an extra layer of accessibility for screen readers, making our software more friendly for visually impaired users.

  • Enhanced Accessibility in SwiperFlatList Component
    The 'SwiperFlatList' feature, a component that supports horizontal scrolling lists, has also been modified. We have introduced the 'paginationAccessibilityLabels' property here as well. This list of textual labels will aid screen readers in providing a more accessible experience for visually impaired users.

@gusgard
Copy link
Owner

gusgard commented Apr 23, 2024

Looks greats thanks for the improvement to the library.

@gusgard gusgard merged commit 40243d3 into gusgard:master Apr 23, 2024
1 check passed
@gusgard
Copy link
Owner

gusgard commented Apr 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants