Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews are accessible even if vocabulary is not yet loaded #67

Open
VadimGush opened this issue Sep 28, 2022 · 0 comments
Open

Reviews are accessible even if vocabulary is not yet loaded #67

VadimGush opened this issue Sep 28, 2022 · 0 comments
Labels
Bug Something isn't working

Comments

@VadimGush
Copy link
Member

In vocabulary section we have review for WaniKani vocabulary. It is not available if user is not logged into WaniKani account. Which is expected, because Kazan doesn't have any data to generate those reviews. But! When user is logged in, it takes some time for web-app to load vocabulary data from WaniKani. But at this moment WaniKani vocabulary review is already available. Of course, if user will start that review while application is trying to load data from WaniKani, user will get an error (or some other type of failure). We want to avoid that.

So, what should we do: if a certain review depends on the data from WaniKani, it shouldn't be available before all data is loaded.

@VadimGush VadimGush added the Bug Something isn't working label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant