New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated some unit tests #111
Conversation
|
||
public function repoUrlProvider() | ||
{ | ||
return array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turn array( into []
👍 please also add yourself to the list on the composer.json, welcome to the Gush core team |
@cordoval Thanks! I have updated the PR. |
$this->markTestIncomplete('needs to be written'); | ||
$return = '## master'; | ||
$this->processHelper | ||
->expects($this->any()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is 4 spaces not 5 or aligned to the upper arrow though
after the indentation is fixed this is good to merge 👍 |
@cordoval Done |
master merges with remote master | ||
Local ref configured for 'git push' (status not queried): | ||
(matching) pushes to (matching) | ||
EOT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) double ;; ??
@pierredup I took your PR and finished it here #115 thanks! good work! 👍 👶 |
Updated unit tests�