New styling commando's #402
Conversation
|
Pull request will now report on which org and repository the pull-request will be opened. |
|
Tests are still broken... will fix them tomorrow. |
|
"still broken" ... hmmm not good not good 👴 😊 |
| public function renderException($e, $output) | ||
| { | ||
| if ($e instanceof UserException) { | ||
| $this->getHelperSet()->get('gush_style')->getStyle()->error($e->getMessage()); |
There was a problem hiding this comment.
Maybe some helper methods like $this->success(...), $this->error(...) etc. will make some of the code less verbose
There was a problem hiding this comment.
I actually thought about that :) but that was a bit to much work for now.
There was a problem hiding this comment.
On the other hand, it would make fixing the tests easier :)
When a UserException is thrown the exception is rendered as error-block instead of an exception-block The original message is still shown when verbosity is increased
This also fixes that the default value of the issue-tracker didn't work
|
The tests are failing due to a bug in the SymfonyStyle, the console width is empty ( Even worse its completely failing when using the Git shell as
Am signing of for today ;) |
|
Tests are working, rendering problems are resolved Ready for merge @cordoval :) |
|
must be a coincidence but @wjzijderveld also has a new github picture i believe. Good job @sstok |
| $issueNumber | ||
| )); | ||
| $adapter->closeIssue($issueNumber); | ||
| if (true === $close ) { |
|
should i merge now? sounds yummy! |
except for LabelIssuesCommand which has to many changes for a combined commit
|
Just fixing some of the reported issue ;) |
- adapt new console styling - allow empty labels - fix labels with spaces between commas - allow using current labels (basically skip) - remove `--label` option (undocumented and dangerous)
|
ok, the git history you have seems impressively clean. I wonder if your train of thought was this clear as you progressed or you reordered it in chunks with git add -p after the whole work was finished. Good work man. I can't wait to merge. 👏 |
|
Doing the commits logically and then doing an interactive rebase ('edit') to fix issues in the original commit 😋 |
|
thanks @kbond for this symfony/symfony#14057, this wouldn't be possible were it not for your efforts. Thanks @pierredup for your excellent review. Thanks @javiereguiluz for the great ideas and diligence. |
MetaHeaderCommand now gives a much nicer detailed output (telling which files are actually changed)
And add little information whats going to happen ``` // This pull-request will be opened on "org/repo". // The source branch is "source-branch" on "source-org". ``` And ask confirmation to replace an issue
* fix wrong rendering * list problems
|
OK, issue are resolved. Ready for merge 👍 Properly my most clean-PR ever 😄 |
|
👍 great work @sstok |
Hehe and I thought I had long hair 😄 |
|
I think if things go well this year I will grow long hair too, not that long but maybe a bit. I mean long ⬜ hair as in 🍼 but sign of an 👴 |
Still a work in progress, but to give an idea :)
Images were edited with Paint so not a full shot ;)
Todo: