Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this package use the ignore settings in package.json? #54

Open
saadq opened this issue Jul 9, 2017 · 4 comments
Open

Does this package use the ignore settings in package.json? #54

saadq opened this issue Jul 9, 2017 · 4 comments

Comments

@saadq
Copy link

saadq commented Jul 9, 2017

If i have a packge.json file like this:

{
  "scripts": {
    "lint": "standard | snazzy"
  },
  "standard": {
    "ignore": [
      "some-dir-name"
    ]
  }
}

Is the package supposed to respect the ignore setting I have in the standard config? I don't get any errors from running npm run lint because some-dir-name is ignored, but when I open a file in some-dir-name in Atom, it shows linting errors within the editor. Is there a way to not have the linter run in files that should be ignored?

@novemberborn
Copy link
Collaborator

@saadq no that should work. Any chance you could share your product, or put up a repository that reproduces the issue?

@saadq
Copy link
Author

saadq commented Jul 9, 2017

I've added a simple repo here. If you run npm run lint or npm test, it doesn't display any errors. However, when I open a file that should be ignored in the editor, it displays this:

screen shot 2017-07-09 at 1 07 30 pm

Some additional details:

  • OS: macOS Sierra Version 10.12.2
  • Atom Version: 1.18.0
  • linter-js-standard-engine version: 2.1.0
  • standard version: ^10.0.2

I believe I was also having the same issue when using linter-js-standard, so it's definitely possible I have something set up incorrectly. Please let me know if this issue isn't happening for you, and then maybe I can try with a clean install of atom with nothing but your package installed.

@novemberborn
Copy link
Collaborator

Thanks, I can reproduce that locally.

@gustavnikolaj
Copy link
Owner

Thanks for the report. I have opened a PR #55 with some exploration of the issue. Will have to look at it later. Sorry for the late reply, I've been on vacation and busy at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants