add dedent

[mjuksel]

No description provided.

[gustavoguichard]

Hi @mjuksel ! Thanks for the new PR!
I like the overall code but I feel like it could follow our standards a lil more, by reusing internal functions that are already available such as trim, replace, slice, split, etc.

Did you find any barrier on using those?

[mjuksel]

Did you find any barrier on using those?

@gustavoguichard I kind of did yeah.

• Trim doesn't take an argument, so it can't remove new lines.
• Using Split<data, '\n'> removes the trailing empty line for some reason?
• Because of that, join keeps a leading empty line.
• Can't filter out leading/trailing empty lines from the split data, as it will remove empty lines everywhere.

So either we should modify the existing types/functions a bit, or use it this way 😄

[gustavoguichard]

Interesting, lemme think about it... maybe we are seeing some weaknesses of the other methods.
cc: @jly36963

[mjuksel]

Interesting, lemme think about it... maybe we are seeing some weaknesses of the other methods.

Right.

Trim type can just have an argument added, but that means we can't use the native trim method.
That can easily be solved by replacing it with the one I have here, or something similar.

I'm assuming most of them are easy fixes/tweaks!