Fix environment variable usage for local provisioners

gusztavvargadr · Jan 14, 2024 · 068ec77 · 068ec77
1 parent 7b522d2
commit 068ec77
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 24 deletions.
diff --git a/src/ubuntu/build.native.pkr.hcl b/src/ubuntu/build.native.pkr.hcl
@@ -52,14 +52,10 @@ build {
 
   provisioner "shell-local" {
     inline = [
-      "chef install",
+      "chef install --chef-license accept-silent",
       "chef update --attributes",
       "chef export ${local.artifacts_directory}/chef --force"
     ]
-
-    env = {
-      CHEF_LICENSE = "accept-silent"
-    }
   }
 }
 

diff --git a/src/ubuntu/build.vagrant.pkr.hcl b/src/ubuntu/build.vagrant.pkr.hcl
@@ -105,21 +105,19 @@ build {
     valid_exit_codes = [0, 1]
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 
   provisioner "shell-local" {
     inline = [
-      "vagrant up local"
+      "vagrant up local --provider ${lookup(local.vagrant_providers, local.image_provider, "")}"
     ]
 
     max_retries = 1
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 
@@ -132,8 +130,7 @@ build {
     valid_exit_codes = [0, 1]
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 }

diff --git a/src/windows/build.native.pkr.hcl b/src/windows/build.native.pkr.hcl
@@ -53,14 +53,10 @@ build {
 
   provisioner "shell-local" {
     inline = [
-      "chef install",
+      "chef install --chef-license accept-silent",
       "chef update --attributes",
       "chef export ${local.artifacts_directory}/chef --force"
     ]
-
-    env = {
-      CHEF_LICENSE = "accept-silent"
-    }
   }
 }
 

diff --git a/src/windows/build.vagrant.pkr.hcl b/src/windows/build.vagrant.pkr.hcl
@@ -110,21 +110,19 @@ build {
     valid_exit_codes = [0, 1]
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 
   provisioner "shell-local" {
     inline = [
-      "vagrant up local"
+      "vagrant up local --provider ${lookup(local.vagrant_providers, local.image_provider, "")}"
     ]
 
     max_retries = 1
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 
@@ -137,8 +135,7 @@ build {
     valid_exit_codes = [0, 1]
 
     env = {
-      VAGRANT_DEFAULT_PROVIDER = "${lookup(local.vagrant_providers, local.image_provider, "")}"
-      VAGRANT_BOX_URL          = "${local.artifacts_directory}/vagrant/vagrant.box"
+      VAGRANT_BOX_URL = "${local.artifacts_directory}/vagrant/vagrant.box"
     }
   }
 }