Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to run under Mac OS X #73 #84

Closed
wants to merge 6 commits into from

Conversation

boustedo
Copy link

@boustedo boustedo commented Mar 31, 2018

Adding ci.sh boostrapper to run it under Mac OS X and probably Linux.
Upgrade Cake to release 0.22.2 with latest addin.

Resolves #73.

@gusztavvargadr gusztavvargadr changed the title Fix to run under Mac OS X Fix to run under Mac OS X #73 Mar 31, 2018
@gusztavvargadr gusztavvargadr added the enhancement New feature or request label Mar 31, 2018
@gusztavvargadr gusztavvargadr added this to the 1803.0.0 milestone Mar 31, 2018
@gusztavvargadr
Copy link
Owner

@boustedo thanks heaps for the contribution! I'll try to do some tests myself (though I have access only to Linux atm), and will get back to you.

@boustedo
Copy link
Author

boustedo commented Apr 3, 2018

@gusztavvargadr I just run .\ci.ps1 restore w10e-virtualbox-core of my PR change under Windows and I got this error:

An error occurred when executing task 'packer-restore'. Error: System.AggregateException: One or more errors occurred. ---> System.MissingMethodException: Method not found: 'Newtonsoft.Json.Linq.JObject Cake.Json.JsonAliases.ParseJsonFromFile(Cake.Core.ICakeContext, Cake.Core.IO.FilePath)'.

I am trying to debug it but I am lost a little bit since I was unable to debug under VS Code yet.

The error is trigger from this line https://github.com/boustedo/packer-templates/blob/master/src/core/cake/template.cake#L214

It work well under MacOSX and Linux using: ./ci.sh --target restore --configuration w10e-virtualbox-core.

I do not understand why it work on other platform but not on Windows. Maybe it's my Windows environment that is the source of the error. But I doubt it. I will continue to debug that. If you have any hint on it, please share and we will find a way to make it work on all platform.

@gusztavvargadr
Copy link
Owner

@boustedo thanks for the great analysis, sorry that I did not have the time yet to test it properly.

I can recall I had to fix the versions when 0.22.0 was released at 81536dd#diff-d1b4d7717b81225f983e4c6df57971ea as the dependencies got broken.

I would try the later versions of https://www.nuget.org/packages/Newtonsoft.Json/, maybe it's just an incorrect minimal version specification in Cake.Json. Btw, if we're not directly referencing Newtonsoft.Json, I would not add it as an explicit addin, as that's the responsibility of Cake.Json.

@boustedo
Copy link
Author

@gusztavvargadr
I make it work by running the Cake.CoreCLR dll with dotnet instead of using the Cake.exe binary. I also have to skip the verification. I don't understand why it work using "dotnet Cake.dll [...]". I will not investigate more for the moment. If you need me to test other stuff, let me know.

@gusztavvargadr gusztavvargadr removed this from the 1803.0.0 milestone May 6, 2018
@gusztavvargadr
Copy link
Owner

@boustedo sorry that I never got to properly test and so merge this. I'm planning to move to the .NET Core tool model soon, so I'm closing this now.

https://cakebuild.net/blog/2018/08/cake-v0.30.0-released

Thanks again!

@gusztavvargadr gusztavvargadr added duplicate and removed enhancement New feature or request labels Oct 8, 2019
@gusztavvargadr gusztavvargadr added the enhancement New feature or request label Jun 11, 2020
@gusztavvargadr gusztavvargadr added this to the 2006.0.0 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure building and consuming boxes works across multiple OSes
2 participants