Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fished" not showing up in results #27

Closed
ivanmkc opened this issue Dec 25, 2021 · 3 comments
Closed

"Fished" not showing up in results #27

ivanmkc opened this issue Dec 25, 2021 · 3 comments

Comments

@ivanmkc
Copy link

ivanmkc commented Dec 25, 2021

I was running a simple test.

get_word_forms("fish")

However, "fished" is not showing us as expected under "v".

Actual results:
{'n': {'fisher', 'fisheries', 'fishery', 'fishers', 'fishings', 'fishing', 'fish'}, 'a': {'fishy'}, 'v': {'fish'}, 'r': {'fishily'}}

@ivanmkc
Copy link
Author

ivanmkc commented Dec 25, 2021

This has quite a lot of issues with past tense.

@tomaarsen
Copy link
Contributor

This is due to fish not appearing in en-verbs. word_forms is only able to find verbs other than the lemma if the lemma is in that file. It should be noted that word_forms is definitely not perfect.

@gutfeeling
Copy link
Owner

Yup, exactly what @tomaarsen said.

Our approach is limited to Wordnet and the en-verbs list. Neither is complete.

Still, I sympathize with your issue @ivanmkc, but I don't have any ideas to fix it in a scalable way. Adding missing verbs manually is effort intensive with marginal benefits.

So I am going to close the issue. If you have any suggestions, you can still comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants