Convert WASM bridge to TypeScript #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Aug 11, 2022
Co-authored-by: Guy Bedford <guybedford@gmail.com>
Thanks! Comments addressed. |
guybedford
reviewed
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #127, this PR converts the WASM JavaScript bridge to TypeScript.
I suggest looking at each commit individually for the best diffs. There's an intermediate commit that shows the differences between the original and newly generated
.jsandd.tsfiles. The next commit deletes them, since I don't think we want those artifacts checked in?There shouldn't be any user-affecting changes in this PR.
dist/lexer.jsends up being byte-for-byte identical, andtypes/lexer.d.tsshould be semantically identical (verified manually), though with slightly different formatting.For the build, I am using swc + chomp to generate the
.jsfile as requested in #127 (comment). It worked great! However, since swc doesn't generate.d.tsfiles, I also included a chomptscstep with the--emitDeclarationOnlyflag. Hopefully this is OK? The two steps can at least run in parallel.Thanks!