Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for import assertions #74

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Conversation

guybedford
Copy link
Owner

@guybedford guybedford commented Jun 14, 2021

Adds support for parsing import assertions.

Three variables are used - "a", "as" and "ae".

For static imports these correspond to:

  • "a": The start of the "assert" keyword in the static import statement
  • "as": The { start of the assertion
  • "ae": The } end of the assertion

For dynamic imports, "as" and "ae" are not used, instead only "a":

  • "a": The index immediately after the , - so { in the dynamic import expression import('specifier', {...})
  • "e": Is updated to reference the end of the specifier portion before the , in the import expression, instead of the position before the closing ). This is effectively a breaking change to the dynamic import handling.
  • "ss": Remains but is now documented as the start of the dynamic import(... expression itself.
  • "se": Is updated to reference the end of the import expression (position of the closing )).

Resolves #73.

@guybedford guybedford merged commit 770481e into main Jun 14, 2021
@guybedford guybedford deleted the import-assertions branch June 14, 2021 22:41
@LarsDenBakker
Copy link
Contributor

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose information about import assertions
2 participants