feat: asm.js build #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you have any numbers on this? |
|
The numbers are in the readme perf diff - https://github.com/guybedford/es-module-lexer#benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an asm.js build of es-module-lexer, built using Emscripten 1.40.1 that still supported asm.js builds.
This fixes the cold start problem we have with the JS build, while still fully supporting CSP.
The output size minified and brotli'd is 4.7KB, as opposed to 5.2KB for the JS and 4.5KB for the Wasm builds.
With optimizations turned up, performance is comparable to Wasm!