Fix immediately added dynamic import maps #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovacodes
commented
May 14, 2021
vovacodes
force-pushed
the
fix/immediately-added-dynamic-import-map
branch
from
2fd7510
to
637fc6e
Compare
guybedford
reviewed
May 14, 2021
|
@guybedford I think I'm ready to merge it if my response to your comments makes sense to you. |
vovacodes
force-pushed
the
fix/immediately-added-dynamic-import-map
branch
from
637fc6e
to
6f594e6
Compare
guybedford
reviewed
May 14, 2021
guybedford
approved these changes
May 14, 2021
vovacodes
force-pushed
the
fix/immediately-added-dynamic-import-map
branch
from
b9ecc18
to
c7bbb01
Compare
vovacodes
force-pushed
the
fix/immediately-added-dynamic-import-map
branch
from
c7bbb01
to
e082019
Compare
|
@guybedford do you mind publishing a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft adds a failing test (
http://localhost:8080/test/dynamic-import-map-shim.html) for the scenario when an import map is inserted dynamically from JS andimportShim()that is trying to import a bare module specifier defined in that dynamic import map is called right after the insertion.In the state after the first commit the code works in Safari and prints the following to the console
but it fails in Chrome with printing the following:
The second commit fixes it.