Revoke blob URLs after the module is loaded #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
May 15, 2021
src/es-module-shims.js
Outdated
| function revokeObjectURLs(registryKeys) { | ||
| function cleanup() { | ||
| for (const key of registryKeys) { | ||
| const blobURL = registry[key]?.b; |
There was a problem hiding this comment.
I'm not sure if we have optional chaining for early modules implementations...
vovacodes
force-pushed
the
feature/revoke-object-urls
branch
2 times, most recently
from
69f19b9
to
59e43a8
Compare
vovacodes
force-pushed
the
feature/revoke-object-urls
branch
from
59e43a8
to
de4e60c
Compare
guybedford
approved these changes
May 16, 2021
|
@guybedford ha, good point actually, I can maybe look into that later 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.