Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take base href into account when resolving relative urls #26

Merged
merged 1 commit into from Jun 29, 2019
Merged

Take base href into account when resolving relative urls #26

merged 1 commit into from Jun 29, 2019

Conversation

LarsDenBakker
Copy link
Contributor

@LarsDenBakker LarsDenBakker commented Jun 28, 2019 •
edited

The same change as: systemjs/systemjs#1957 to solve the issue described here: systemjs/systemjs#1956

guybedford
guybedford approved these changes Jun 29, 2019
View reviewed changes
Copy link
Owner

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you please leave the dist build out of the PR to simplify the merge diff as well.

Thanks so much for posting this.

dist/es-module-shims.js Outdated Show resolved Hide resolved
@LarsDenBakker
Copy link
Contributor Author

Made the changes :)

@guybedford guybedford merged commit f5c33a8 into guybedford:master Jun 29, 2019
@guybedford guybedford mentioned this pull request Jun 29, 2019
Merged
@guybedford
Copy link
Owner

Released in 0.2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LarsDenBakker @guybedford