Change property readers to camelCasing #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The casing of the `<script>` element's [crossorigin][] and [referrerpolicy][] HTML _attributes_ differ from the casing of [HTMLScriptElement.crossOrigin][] and [HTMLScriptElement.referrerPolicy][] _properties_. Prior to this commit, the implementation erroneously attempted to read values from the _properties_ through names cased as if they were _attributes_. This commit replaces the lower-cased accesses with camelCased ones. [crossorigin]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-crossorigin [referrerpolicy]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-referrerpolicy [HTMLScriptElement.crossOrigin]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement#instance_properties [HTMLScriptElement.referrerPolicy]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement/referrerPolicy
seanpdoyle
force-pushed
the
proprty-casing
branch
from
83b83ff
to
e111ae0
Compare
|
Amazing, thanks so much for catching this one. The logic was right, just not the implementation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casing of the
<script>element's crossorigin and referrerpolicy HTML attributes differ from the casing of HTMLScriptElement.crossOrigin andHTMLScriptElement.referrerPolicy properties.
Prior to this commit, the implementation erroneously attempted to read values from the properties through names cased as if they were attributes.
This commit replaces the lower-cased accesses with camelCased ones.