New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #381 #382 #383

Merged

guybedford merged 1 commit into guybedford:main from loynoir:bugfix-381

Aug 6, 2023

Contributor

loynoir commented Aug 6, 2023 •

edited

fixed No types #381

Base on assumption ./dist/es-module-shims.js ./dist/es-module-shims.debug.js ./dist/es-module-shims.wasm.js have same type.

Verified with npm pack and https://arethetypeswrong.github.io,

fixed there should be less require property #382

Base on assumption window.esmsInitOptions = {} is valid, like example

Better type

   * Enable polyfill features.
   * Currently supports ['css-modules', 'json-modules']
   */
-  polyfillEnable?: string[];
+  polyfillEnable?: Array<'css-modules' | 'json-modules'>


          fix guybedford#381 guybedford#382

ab59ab8

Owner

guybedford commented Aug 6, 2023

Thanks for the PR.

guybedford merged commit dbd348c into guybedford:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment