Add response to response errors #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Sep 10, 2023
guybedford
approved these changes
Sep 10, 2023
|
Hey @guybedford; is there a cadence to releases? I couldn't find anything in the README and I'm happy to just build it myself if required but thought I'd ask before doing that :) |
|
@koddsson thanks for the ping, |
|
(also if anyone would like to volunteer as a co-maintainer, that is always welcome!!) |
Happy to help with anything <3 Something like reviewing, merging and releasing pull requests and managing issues? |
|
@koddsson I've added you to the repo, help with issue triage and PR review would be great, then ping me if you ever would like to do a release. Of course there are no obligations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
(I couldn't find any notes on contributing so I assumed that PRs are welcome but if not, no worries)
I want to filter response errors throw in
es-module-shimsbased off some criteria of their response. I find parsing the error message a bit brittle but I could get the information from there. Before doing that I wanted to suggest sub-classing theErrorclass with aResponseErrorwhich includes the actual response and then throwing that error when a response error occurs.What do you think? I added a single test but I can add some more to increase confidence.