Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetch hook #73

Merged
merged 2 commits into from Oct 21, 2019
Merged

Implement fetch hook #73

merged 2 commits into from Oct 21, 2019

Conversation

guybedford
Copy link
Owner

This implements a very simple fetch hook for this project (two line change!).

It should open up some quite powerful workflows like TypeScript in-browser on native modules.

README.md Outdated Show resolved Hide resolved
@zaygraveyard
Copy link

This is awesome, it works like a charm, thank you 👍

Even-though I like and am in support of this feature, one nitpick I have is that up until this change, this library was more like a polyfill (it didn't do anything that wouldn't have been possible natively) but this feature is something that wont be possible natively.
Maybe add a warning next to this feature in the README?

PS: My current use-case is only in development (for running tests)

@guybedford
Copy link
Owner Author

Thanks for the review! I've included a note re spec-compatibility, and that's a good point for sure.

@guybedford guybedford merged commit 99a59a8 into master Oct 21, 2019
@guybedford guybedford deleted the fetch-hook branch October 21, 2019 15:10
@guybedford
Copy link
Owner Author

Released in 0.4.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants