Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AngularJS dependency version 1.4 #18

Closed
georgwittberger opened this issue Nov 21, 2015 · 1 comment
Closed

Allow AngularJS dependency version 1.4 #18

georgwittberger opened this issue Nov 21, 2015 · 1 comment
Assignees
Milestone

Comments

@georgwittberger
Copy link

Your bower.json requires AngularJS to be version ~1.3.15 which means any patch level greater than 1.3.15 but definitely a version less than 1.4. In my current project I would like to use the most recent AngularJS version 1.4.8 together with your module. The only way to make it work is to provide a custom resolution in my bower.json which forces Bower to use version 1.4.8. This is a dirty workaround and produces warning during the build process.
I have already tested your module in conjunction with AngularJS 1.4.8 and it seems to work fine for my use cases. Therefore, could you please update your bower.json to allow the recent version?

For example you could use the caret prefix instead: ^1.3.15 - This allows any minor version greater than 1.3.15 and less than 2.0, see https://github.com/npm/node-semver#caret-ranges-123-025-004

@guylabs guylabs added this to the 0.4.4 milestone Dec 23, 2015
@guylabs guylabs self-assigned this Dec 23, 2015
@guylabs
Copy link
Owner

guylabs commented Dec 23, 2015

Hi Georg,

sorry for my late response but I didn't have the time to do it earlier. I just released 0.4.4 of the module which uses Angular 1.4.8. So you just need to update to 0.4.4 and then you can use it the proper way.

I will close the issue now. If you have anything else please comment it here or reopen the issue.

Happy christmas! :)

Regards,

Guy

@guylabs guylabs closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants