Fixed IllegalArgumentException in ShowSettingsUtilImpl

When trying to resolve dependencies without an Ivy settings file, an IllegalArgumentException was thrown when clicking on the 'Open Project Settings' link
guymahieu · May 19, 2016 · 0dad4f3 · 0dad4f3
1 parent 70357da
commit 0dad4f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/build.xml b/build.xml
@@ -16,7 +16,7 @@
 
 <project name="IvyIDEA" default="bundle" basedir=".">
 
-    <property name="ivyidea.version" value="1.0.13"/>
+    <property name="ivyidea.version" value="1.0.14"/>
 
     <property name="ivyidea.sourcedir" value="src/main/java"/>
     <property name="ivyidea.resourcedir" value="src/main/resources"/>

diff --git a/src/main/java/META-INF/plugin.xml b/src/main/java/META-INF/plugin.xml
@@ -16,6 +16,11 @@
     </description>
     <change-notes><![CDATA[
         <p>
+            <strong>1.0.14</strong>
+            <ul>
+                <li>When trying to resolve dependencies without an Ivy settings file, an IllegalArgumentException 
+				    was thrown when clicking on the 'Open Project Settings' link</li>
+            </ul>
             <strong>1.0.13</strong>
             <ul>
                 <li>The IvyIDEA settings window was no longer visible in IntelliJ 2016.1</li>
@@ -113,7 +118,7 @@
             </ul>
         </p>]]>
     </change-notes>
-    <version>1.0.13</version>
+    <version>1.0.14</version>
     <vendor email="guy.mahieu@gmail.com" url="http://www.clarent.org" logo="/ivyidea16.png">Guy Mahieu</vendor>
     <idea-version since-build="3000"/>
     <application-components>

diff --git a/src/main/java/org/clarent/ivyidea/intellij/task/IvyIdeaResolveBackgroundTask.java b/src/main/java/org/clarent/ivyidea/intellij/task/IvyIdeaResolveBackgroundTask.java
@@ -129,8 +129,7 @@ private void showIvySettingsNotFoundErrorDialog(IvySettingsNotFoundException exc
                     "Open " + exception.getConfigLocation() + " settings for " + exception.getConfigName() + "...",
                     new LinkListener() {
                         public void linkSelected(LinkLabel linkLabel, Object o) {
-                            Configurable component = project.getComponent(IvyIdeaProjectSettingsComponent.class);
-                            ShowSettingsUtil.getInstance().editConfigurable(project, component);
+                            ShowSettingsUtil.getInstance().showSettingsDialog(project, IvyIdeaProjectSettingsComponent.class);
                         }
                     }, null);
         }