Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redefining kernel help_links with ILUA_HELP_LINKS environment variable #23

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jan 26, 2022

The ILUA_HELP_LINKS variable can be set in kernel.json file like this:

{
	"argv":
	[
		"python",
		"-m",
		"ilua.app",
		"-c",
		"{connection_file}",
		"-i",
		"rpmlua"
	],
	"display_name": "RPM Lua",
	"language": "lua",
	"interrupt_mode": "message",
	"env": {
		"ILUA_HELP_LINKS": "[{\"text\": \"Lua in RPM\", \"url\": \"https://rpm-software-management.github.io/rpm/manual/lua.html\"}]"
	}
}

The nested json in json syntax is a bit hard to read,
but OTOH json works well for serializing a list of dictionaries to an environment variable.

Fixes #15

…ariable

The ILUA_HELP_LINKS variable can be set in kernel.json file like this:

    {
    	"argv":
    	[
    		"python",
    		"-m",
    		"ilua.app",
    		"-c",
    		"{connection_file}",
    		"-i",
    		"rpmlua"
    	],
    	"display_name": "RPM Lua",
    	"language": "lua",
    	"interrupt_mode": "message",
    	"env": {
    		"ILUA_HELP_LINKS": "[{\"text\": \"Lua in RPM\", \"url\": \"https://rpm-software-management.github.io/rpm/manual/lua.html\"}]"
    	}
    }

The nested json in json syntax is a bit hard to read,
but OTOH json works well for serializing a list of dictionaries to an environment variable.

Fixes guysv#15
@guysv
Copy link
Owner

guysv commented Jan 27, 2022

great work 😅

@guysv guysv merged commit 05eb181 into guysv:master Jan 27, 2022
@hroncok hroncok deleted the help_links_env branch January 27, 2022 11:11
@hroncok
Copy link
Contributor Author

hroncok commented Apr 13, 2022

@guysv May I kindly ask you for a new release?

@guysv
Copy link
Owner

guysv commented Apr 13, 2022

Oh man that maintenance was due. I hear you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: A way to pass additional help_links from kernel.json
2 participants