Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gitlab 2FA support #54

Closed
guyzmo opened this issue Oct 16, 2016 · 1 comment
Closed

Implement gitlab 2FA support #54

guyzmo opened this issue Oct 16, 2016 · 1 comment
Labels
Milestone

Comments

@guyzmo
Copy link
Owner

guyzmo commented Oct 16, 2016

The same way github's 2FA support has been recently added (cf #39) implement gitlab's 2FA as well.

Even though implementing 2FA with github was easy thanks to @sigmavirus24's work on sigmavirus24/github3.py where it was already implemented… Doing it on gitlab needs to start with patching gpocentex/python-gitlab to implement a 2FA callback… Looking at the code it looks like there's no mechanism in place for that yet:

That being said, it is unclear how to use 2FA and whether a mechanism is in place for using it with Gitlab's API, as there's no mention of 2FA in the authentication section of the Gitlab API documentation.

@guyzmo
Copy link
Owner Author

guyzmo commented Dec 28, 2016

ok after skimming through the gitlab API documentation, if you enable 2FA, you cannot login using login+password on the API, and when you use a token (either personal access token or privatekey) you don't have 2FA.

So, as long as this is not supported by gitlab itself, I'll mark this issue as wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant