Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed github name != username issue #41

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fixed github name != username issue #41

merged 1 commit into from
Oct 12, 2016

Conversation

buaazp
Copy link
Contributor

@buaazp buaazp commented Oct 11, 2016

Details:

My github username(gh.user().login) is buaazp while my github name is 招牌疯子, so the remote url is wrong after I fork a repo.

[zippo@rMBP] ➜ git-repo (master) git remote -v
all git@github.com:guyzmo/git-repo (fetch)
all git@github.com:guyzmo/git-repo (push)
github  git@github.com:guyzmo/git-repo (fetch)
github  git@github.com:guyzmo/git-repo (push)

[zippo@rMBP] ➜ git-repo (master) git hub fork
Forking repository guyzmo/git-repo…
New forked repository available at https://github.com/buaazp/git-repo

[zippo@rMBP] ➜ git-repo (master) git remote -v
all git@github.com:招牌疯子/git-repo (push)
all git@github.com:guyzmo/git-repo (fetch)
all git@github.com:guyzmo/git-repo (push)
github  git@github.com:招牌疯子/git-repo (fetch)
github  git@github.com:招牌疯子/git-repo (push)
upstream    git@github.com:guyzmo/git-repo (fetch)
upstream    git@github.com:guyzmo/git-repo (push)

@guyzmo
Copy link
Owner

guyzmo commented Oct 11, 2016

Hello! Thank you a lot for spotting this, and I'm really really sorry for the mistake, that might have many side effects for users ☹

Though, so I can merge it, could you please remove the OSX fix from this commit, and move it into a separate commit and PR?

@buaazp
Copy link
Contributor Author

buaazp commented Oct 11, 2016

sure, wait a minute.

@guyzmo guyzmo added the backlog label Oct 12, 2016
@guyzmo guyzmo merged commit 0bb3732 into guyzmo:master Oct 12, 2016
@guyzmo guyzmo removed the backlog label Oct 12, 2016
@buaazp buaazp deleted the fix/gs_name branch October 13, 2016 05:09
guyzmo added a commit that referenced this pull request Oct 13, 2016
Bugfixes:

* 💄 Fixed issue with cursor sometimes disappearing after run
* 🚒 Fixed setup of gitlab URI of personal repo services (cf #36)
* 🚒 Fixed error handling in format_path and create action
* 🚒 Fixed overconstrained gitpython version (cf #40)
* 🚒 Fixed issue where lastname was used for username (cf #41 and #44)
* 💄 Fixed typos in README (cf #45, #42)

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
guyzmo added a commit that referenced this pull request Oct 13, 2016
Bugfixes:

* 💄 Fixed issue with cursor sometimes disappearing after run
* 🚒 Fixed setup of gitlab URI of personal repo services (cf #36)
* 🚒 Fixed error handling in format_path and create action
* 🚒 Fixed overconstrained gitpython version (cf #40)
* 🚒 Fixed issue where lastname was used for username (cf #41 and #44)
* 💄 Fixed typos in README (cf #45, #42)

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
guyzmo added a commit that referenced this pull request Oct 13, 2016
Bugfixes:

* 💄 Fixed issue with cursor sometimes disappearing after run
* 🚒 Fixed setup of gitlab URI of personal repo services (cf #36)
* 🚒 Fixed error handling in format_path and create action
* 🚒 Fixed overconstrained gitpython version (cf #40)
* 🚒 Fixed issue where lastname was used for username (cf #41 and #44)
* 💄 Fixed typos in README (cf #45, #42)

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants