Fix Guzzle error processing with http_errors=true #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Nov 3, 2021
|
@GrahamCampbell |
|
Could you add a unit test please? Then I'll be happy to merge. |
|
@GrahamCampbell sorry, have not time for continue this pr. Can you help me with tests? |
|
I don't have any capacity for this. I think we just need to say that that we require people not use that mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Guzzle option http_errors=true this errorResponses not processing and this code skipped during exception:
yield $this->transformResponseToResult($response, $request, $command);This fix allow errorResponses mappings from Description.
If error not found in errorResponses than Guzzle error will propagate.