Added tests for JSON array of arrays and array of objects #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konafets
suggested changes
Jan 31, 2017
| */ | ||
| public function testVisitsNestedArrayOfObjects() | ||
| { | ||
| $json = json_decode('{"scalar":"foo","nested":[{"bar":123,"baz":false},{"bar":345,"baz":true},{"bar":678,"baz":true}]}'); |
There was a problem hiding this comment.
Can you just copy the code from line 371. Its more clear and consistent.
There was a problem hiding this comment.
Can you explain a bit more. Code from line 371 defines array of arrays. Line 469 with json_decode generates array of objects. Descriptions for both are a bit different but important enough to keep them separate.
Konafets
approved these changes
Jan 31, 2017
|
@selfcatering, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out how to write proper descriptions for JSON nested arrays of arrays and arrays of objects. Current JsonResponse seems to cover that quite well, but documentation is lacking instructions on how to properly write descriptions. This PR covers both scenarios and comments explain all the mandatory description elements. Hope that helps someone in the future.