Bring more flexibility to query params serialization #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danizord
approved these changes
Jan 31, 2017
|
@bakura10, thanks for your contribution! I remembering having the very same issue with an Meteor API. Added the removing of the indices to a custom client. This solution is way more better :-) |
|
You're welcome. May I ask a tag another time? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more flexibility to the way query params are serialized and does not introduce any breaking change.
This also open the road to more query serialization logic in the future (like what Guzzle 3 used to have). In my case i needed this as the API I integrated did not support numeric indices in the query string.