Corrected docs and default connect timeout value to 300 seconds (#3075)

Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
guzzle · May 14, 2023 · 39ad11f · 39ad11f
1 parent 15c3f69
commit 39ad11f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/request-options.rst b/docs/request-options.rst
@@ -282,7 +282,7 @@ connect_timeout
 ---------------
 
 :Summary: Float describing the number of seconds to wait while trying to connect
-        to a server. Use ``0`` to wait indefinitely (the default behavior).
+        to a server. Use ``0`` to wait 300 seconds (the default behavior).
 :Types: float
 :Default: ``0``
 :Constant: ``GuzzleHttp\RequestOptions::CONNECT_TIMEOUT``

diff --git a/src/Handler/CurlFactory.php b/src/Handler/CurlFactory.php
@@ -224,7 +224,7 @@ private function getDefaultConf(EasyHandle $easy): array
             \CURLOPT_URL            => (string) $easy->request->getUri()->withFragment(''),
             \CURLOPT_RETURNTRANSFER => false,
             \CURLOPT_HEADER         => false,
-            \CURLOPT_CONNECTTIMEOUT => 150,
+            \CURLOPT_CONNECTTIMEOUT => 300,
         ];
 
         if (\defined('CURLOPT_PROTOCOLS')) {

diff --git a/src/RequestOptions.php b/src/RequestOptions.php
@@ -70,7 +70,7 @@ final class RequestOptions
     /**
      * connect_timeout: (float, default=0) Float describing the number of
      * seconds to wait while trying to connect to a server. Use 0 to wait
-     * indefinitely (the default behavior).
+     * 300 seconds (the default behavior).
      */
     public const CONNECT_TIMEOUT = 'connect_timeout';
 

diff --git a/tests/Handler/CurlFactoryTest.php b/tests/Handler/CurlFactoryTest.php
@@ -66,7 +66,7 @@ public function testCreatesCurlHandle()
         self::assertSame('testing', $_SERVER['_curl'][\CURLOPT_POSTFIELDS]);
         self::assertEquals(0, $_SERVER['_curl'][\CURLOPT_RETURNTRANSFER]);
         self::assertEquals(0, $_SERVER['_curl'][\CURLOPT_HEADER]);
-        self::assertSame(150, $_SERVER['_curl'][\CURLOPT_CONNECTTIMEOUT]);
+        self::assertSame(300, $_SERVER['_curl'][\CURLOPT_CONNECTTIMEOUT]);
         self::assertInstanceOf('Closure', $_SERVER['_curl'][\CURLOPT_HEADERFUNCTION]);
         if (\defined('CURLOPT_PROTOCOLS')) {
             self::assertSame(