Use data providers

guzzle · May 14, 2023 · e30e22e · e30e22e
1 parent b4b154c
commit e30e22e
Showing 1 changed file with 99 additions and 42 deletions.
diff --git a/tests/Cookie/CookieJarTest.php b/tests/Cookie/CookieJarTest.php
@@ -128,55 +128,112 @@ public function testRemovesSelectively()
         self::assertCount(0, $this->jar);
     }
 
-    public function testDoesNotAddIncompleteCookies()
+    public static function providesIncompleteCookies(): array
     {
-        self::assertFalse($this->jar->setCookie(new SetCookie()));
-        self::assertFalse($this->jar->setCookie(new SetCookie([
-            'Name' => 'foo'
-        ])));
-        self::assertFalse($this->jar->setCookie(new SetCookie([
-            'Name' => false
-        ])));
-        self::assertFalse($this->jar->setCookie(new SetCookie([
-            'Name' => true
-        ])));
-        self::assertFalse($this->jar->setCookie(new SetCookie([
-            'Name'   => 'foo',
-            'Domain' => 'foo.com'
-        ])));
+        return [
+            [
+                [],
+            ],
+            [
+                [
+                    'Name' => 'foo',
+                ],
+            ],
+            [
+                [
+                    'Name' => false,
+                ],
+            ],
+            [
+                [
+                    'Name' => true,
+                ],
+            ],
+            [
+                [
+                    'Name'   => 'foo',
+                    'Domain' => 'foo.com',
+                ],
+            ],
+        ];
     }
 
-    public function testDoesNotAddEmptyCookies()
+    /**
+     * @dataProvider providesIncompleteCookies
+     */
+    public function testDoesNotAddIncompleteCookies(array $cookie)
     {
-        self::assertFalse($this->jar->setCookie(new SetCookie([
-            'Name'   => '',
-            'Domain' => 'foo.com',
-            'Value'  => 0
-        ])));
+        self::assertFalse($this->jar->setCookie(new SetCookie($cookie)));
     }
 
-    public function testDoesAddValidCookies()
+    public static function providesEmptyCookies(): array
+    {
+        return [
+            [
+                [
+                    'Name'   => '',
+                    'Domain' => 'foo.com',
+                    'Value'  => 0,
+                ],
+            ],
+            [
+                [
+                    'Name'   => null,
+                    'Domain' => 'foo.com',
+                    'Value'  => 0,
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider providesEmptyCookies
+     */
+    public function testDoesNotAddEmptyCookies(array $cookie)
+    {
+        self::assertFalse($this->jar->setCookie(new SetCookie($cookie)));
+    }
+
+    public static function providesValidCookies(): array
+    {
+        return [
+            [
+                [
+                    'Name'   => '0',
+                    'Domain' => 'foo.com',
+                    'Value'  => 0,
+                ],
+            ],
+            [
+                [
+                    'Name'   => 'foo',
+                    'Domain' => 'foo.com',
+                    'Value'  => 0,
+                ],
+            ],
+            [
+                [
+                    'Name'   => 'foo',
+                    'Domain' => 'foo.com',
+                    'Value'  => 0.0,
+                ],
+            ],
+            [
+                [
+                    'Name'   => 'foo',
+                    'Domain' => 'foo.com',
+                    'Value'  => '0',
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider providesValidCookies
+     */
+    public function testDoesAddValidCookies(array $cookie)
     {
-        self::assertTrue($this->jar->setCookie(new SetCookie([
-            'Name'   => '0',
-            'Domain' => 'foo.com',
-            'Value'  => 0
-        ])));
-        self::assertTrue($this->jar->setCookie(new SetCookie([
-            'Name'   => 'foo',
-            'Domain' => 'foo.com',
-            'Value'  => 0
-        ])));
-        self::assertTrue($this->jar->setCookie(new SetCookie([
-            'Name'   => 'foo',
-            'Domain' => 'foo.com',
-            'Value'  => 0.0
-        ])));
-        self::assertTrue($this->jar->setCookie(new SetCookie([
-            'Name'   => 'foo',
-            'Domain' => 'foo.com',
-            'Value'  => '0'
-        ])));
+        self::assertTrue($this->jar->setCookie(new SetCookie($cookie)));
     }
 
     public function testOverwritesCookiesThatAreOlderOrDiscardable()