Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use \GuzzleHttp\Promise\rejection_for function instead of object init. #1827

Merged
merged 1 commit into from
May 4, 2017
Merged

Use \GuzzleHttp\Promise\rejection_for function instead of object init. #1827

merged 1 commit into from
May 4, 2017

Conversation

Aliance
Copy link
Contributor

@Aliance Aliance commented May 3, 2017

No description provided.

@sagikazarmark
Copy link
Member

Thanks for the PR.

Can you tell me what's the advantage of this?

@Aliance
Copy link
Contributor Author

Aliance commented May 4, 2017 •
edited
Loading

Uniformity. There is an alias functions, it some cases they were used, in others - not. I just made it uniform.
2017-05-04 9 43 41

Sorry for missing the description. I thought it was clear.

@sagikazarmark
Copy link
Member

Hm, okay. I don't really care so much about it, but it's an improvement after all, so thank you.

@sagikazarmark sagikazarmark merged commit 56bf6c1 into guzzle:master May 4, 2017
@Aliance Aliance deleted the rejection_for_alias branch May 5, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aliance @sagikazarmark